Added getDisplayName() method to standardise how the name of an InputTypeInterface class wants to display it's name

src/Input/Interfaces/InputTypeInterface.php

@@ -17,4 +17,6 @@ interface InputTypeInterface
 
     public function getType(): string;
     public function respondsTo(string $name): bool;
+    public function __toString(): string;
+    public function getDisplayName(): string;
 }

src/Input/Types/Argument.php

@@ -25,7 +25,11 @@ class Argument extends Input\AbstractInputType
         parent::__construct($name, $flags, $description, $validator, $default);
     }
 
-    public function __toString()
+    public function getDisplayName(): string {
+        return strtoupper($this->name());
+    }
+
+    public function __toString(): string
     {
         // MAGIC VALUES!!! OH MY.....
         $padCharacter = ' ';
@@ -53,7 +57,7 @@ class Argument extends Input\AbstractInputType
         );
 
         $first = Strings\mb_str_pad(
-            strtoupper($this->name()).str_repeat($padCharacter, $argumentNameMinimumPaddingWidth),
+            $this->getDisplayName().str_repeat($padCharacter, $argumentNameMinimumPaddingWidth),
             $argumentNamePaddedWidth,
             $padCharacter
         );

src/Input/Types/LongOption.php

@@ -24,7 +24,18 @@ class LongOption extends Input\AbstractInputType
         return ($name == $this->name || $name == $this->short);
     }
 
-    public function __toString()
+    public function getDisplayName(): string {
+
+        $short =
+            null !== $this->short()
+            ? '-'.$this->short().', '
+            : null
+        ;
+
+        return sprintf("%s--%s", $short, $this->name());
+    }
+
+    public function __toString(): string
     {
         // MAGIC VALUES!!! OH MY.....
         $padCharacter = ' ';
@@ -51,10 +62,7 @@ class LongOption extends Input\AbstractInputType
             STR_PAD_LEFT
         );
 
-        $short = null !== $this->short() ? '-'.$this->short() : null;
+        $long = $this->getDisplayName();
-        $long = null;
-
-        $long = '--'.$this->name();
         if (Flags\is_flag_set($this->flags(), self::FLAG_VALUE_REQUIRED)) {
             $long .= '=VALUE';
         } elseif (Flags\is_flag_set($this->flags(), self::FLAG_VALUE_OPTIONAL)) {
@@ -62,7 +70,7 @@ class LongOption extends Input\AbstractInputType
         }
 
         $first = Strings\mb_str_pad(
-            (null !== $short ? "{$short}, " : '').$long, // -O, --LONG,
+            $long, // -O, --LONG,
             $optionNamePaddedWidth,
             $padCharacter
         );

src/Input/Types/Option.php

@@ -11,7 +11,11 @@ use pointybeard\Helpers\Cli\Input;
 
 class Option extends Input\AbstractInputType
 {
-    public function __toString()
+    public function getDisplayName(): string {
+        return '-'.$this->name();
+    }
+
+    public function __toString(): string
     {
         // MAGIC VALUES!!! OH MY.....
         $padCharacter = ' ';
@@ -38,10 +42,8 @@ class Option extends Input\AbstractInputType
             STR_PAD_LEFT
         );
 
-        $short = '-'.$this->name();
-
         $first = Strings\mb_str_pad(
-            $short,
+            $this->getDisplayName(),
             $optionNamePaddedWidth,
             $padCharacter
         );