From 9622c9825868cf4ad429ed7cd531175c02bdff94 Mon Sep 17 00:00:00 2001 From: Alannah Kearney Date: Thu, 28 Nov 2019 03:33:52 +0000 Subject: [PATCH 1/2] Removed dev packages from composer.json to avoid circular package dependency version issues and removed example for manpage() method. --- composer.json | 5 ----- example/example.php | 29 ----------------------------- 2 files changed, 34 deletions(-) diff --git a/composer.json b/composer.json index eddd6ad..8eea99b 100644 --- a/composer.json +++ b/composer.json @@ -16,11 +16,6 @@ "pointybeard/helpers-foundation-factory": "~1.0", "pointybeard/helpers-functions-flags": "~1.0" }, - "require-dev": { - "pointybeard/helpers-functions-strings": "~1.1.0", - "pointybeard/helpers-cli-colour": "~1.0", - "pointybeard/helpers-functions-cli": "~1.1.0" - }, "support": { "issues": "https://github.com/pointybeard/helpers-cli-input/issues", "wiki": "https://github.com/pointybeard/helpers-cli-input/wiki" diff --git a/example/example.php b/example/example.php index 76b67e5..1695bf1 100644 --- a/example/example.php +++ b/example/example.php @@ -4,7 +4,6 @@ declare(strict_types=1); include __DIR__.'/../vendor/autoload.php'; use pointybeard\Helpers\Cli\Input; -use pointybeard\Helpers\Cli\Colour\Colour; use pointybeard\Helpers\Functions\Cli; // Define what we are expecting to get from the command line @@ -64,34 +63,6 @@ try { exit; } -// Display the manual in green text -echo Cli\manpage( - basename(__FILE__), - '1.0.2', - 'An example script for the PHP Helpers: Command-line Input and Input Type Handlers composer library (pointybeard/helpers-cli-input).', - $collection, - Colour::FG_GREEN, - Colour::FG_WHITE, - [ - 'Examples' => 'php -f example/example.php -- -vvv -d example/example.json import', - ] -).PHP_EOL.PHP_EOL; - -// example.php 1.0.2, An example script for the PHP Helpers: Command-line Input -// and Input Type Handlers composer library (pointybeard/helpers-cli-input). -// Usage: example.php [OPTIONS]... ACTION... -// -// Arguments: -// ACTION The name of the action to perform -// -// Options: -// -v verbosity level. -v (errors only), -vv -// (warnings and errors), -vvv (everything). -// -d, --data=VALUE Path to the input JSON data -// -// Examples: -// php -f example/example.php -- -vvv -d example/example.json import - var_dump($argv->find('action')); // string(6) "import" From c6fe64321ef06633c89bc055252f22d6ff676d52 Mon Sep 17 00:00:00 2001 From: Norbert Wagner <5166607+n3w@users.noreply.github.com> Date: Thu, 23 Mar 2023 08:47:59 +0100 Subject: [PATCH 2/2] Passing the separator after the array is no longer supported --- src/Input/Types/Argument.php | 2 +- src/Input/Types/LongOption.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Input/Types/Argument.php b/src/Input/Types/Argument.php index 52faec1..4550781 100644 --- a/src/Input/Types/Argument.php +++ b/src/Input/Types/Argument.php @@ -72,6 +72,6 @@ class Argument extends Input\AbstractInputType $second[$ii] = $secondaryLineLeadPadding.$second[$ii]; } - return $first.implode($second, PHP_EOL); + return $first.implode(PHP_EOL, $second); } } diff --git a/src/Input/Types/LongOption.php b/src/Input/Types/LongOption.php index 5961768..17d73de 100644 --- a/src/Input/Types/LongOption.php +++ b/src/Input/Types/LongOption.php @@ -84,6 +84,6 @@ class LongOption extends Input\AbstractInputType $second[$ii] = $secondaryLineLeadPadding.$second[$ii]; } - return $first.implode($second, PHP_EOL); + return $first.implode(PHP_EOL, $second); } }